Skip to content

Add approximate trimming to reactive stream extensions #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add approximate trimming to reactive stream extensions #2227

wants to merge 2 commits into from

Conversation

Quantum64
Copy link

This change adds the approximateTrimming option to the reactive stream operations coroutines extension. I do not think this change warrants an additional test case since this function is already covered, but let me know if it does.

The @JvmOverloads annotation was added to maintain compatibility with previous versions of this class. Binary compatibility is maintained, so this change is fully compatible and non-breaking. Binary compatibility was confirmed using the javap command.

Before

public static final <K, HK, HV> java.lang.Object trimAndAwait(org.springframework.data.redis.core.ReactiveStreamOperations<K, HK, HV>, K, long, kotlin.coroutines.Continuation<? super java.lang.Long>);

After

public static final <K, HK, HV> java.lang.Object trimAndAwait(org.springframework.data.redis.core.ReactiveStreamOperations<K, HK, HV>, K, long, boolean, kotlin.coroutines.Continuation<? super java.lang.Long>);
public static java.lang.Object trimAndAwait$default(org.springframework.data.redis.core.ReactiveStreamOperations, java.lang.Object, long, boolean, kotlin.coroutines.Continuation, int, java.lang.Object);
public static final <K, HK, HV> java.lang.Object trimAndAwait(org.springframework.data.redis.core.ReactiveStreamOperations<K, HK, HV>, K, long, kotlin.coroutines.Continuation<? super java.lang.Long>);

@pivotal-cla
Copy link

@Quantum64 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@Quantum64 Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 7, 2022
@Quantum64 Quantum64 force-pushed the feature/coroutines-trim-approximate branch from 6fa393f to 19ddfe9 Compare January 7, 2022 07:22
@mp911de mp911de self-assigned this Mar 9, 2022
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 9, 2022
@mp911de mp911de added this to the 2.7.4 (2021.2.4) milestone Sep 21, 2022
mp911de pushed a commit that referenced this pull request Sep 21, 2022
@Quantum64 @mp911de
Add approximate trimming to reactive stream extensions.
da816c1 
See #2227
@mp911de mp911de closed this in a0bcf01 Sep 21, 2022
mp911de pushed a commit that referenced this pull request Sep 21, 2022
@Quantum64 @mp911de
Add approximate trimming to reactive stream extensions.
89f4c7e 
See #2227
mp911de added a commit that referenced this pull request Sep 21, 2022
@mp911de
Polishing.
899dca4 
Unroll extension to avoid JvmOverload usage.

Closes #2227
@mp911de
Copy link
Member

mp911de commented Sep 21, 2022

Thank you for your contribution. That's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.7.4 (2021.2.4)
Development

Successfully merging this pull request may close these issues.
4 participants
@Quantum64 @pivotal-cla @mp911de @spring-projects-issues